From b83cd25169a92a8b6d19cab9eeae51fd042e57ad Mon Sep 17 00:00:00 2001 From: Danila Fedorin Date: Fri, 15 May 2020 21:50:52 -0700 Subject: [PATCH 1/2] Add code review remarks. --- REVIEW.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 REVIEW.md diff --git a/REVIEW.md b/REVIEW.md new file mode 100644 index 0000000..402915e --- /dev/null +++ b/REVIEW.md @@ -0,0 +1,7 @@ +# Code Review Changes +|Comment|Adjustment| +|-------|----------| +|Some variables are unused.| Some unused variables needed for external library configuration; others have been removed in the process of refactoring.| +|Comments are lacking.| File has been thoroughly commented.| +|Replace `coord*x` and `coord*y` with arrays (undo unroll). | No action taken. The variables are this way due to the restrictions of the team's protobuf library, which is the only library capable of generating code small enough to fit on the hardware.| +|Few unit tests.|Some unit tests added to the code for encoding and decoding.| From e84c09c754a39ddb62dc9fd435b18e168edb8cf4 Mon Sep 17 00:00:00 2001 From: Danila Fedorin Date: Fri, 15 May 2020 21:56:09 -0700 Subject: [PATCH 2/2] Add Google Doc link. --- REVIEW.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/REVIEW.md b/REVIEW.md index 402915e..3a77264 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -1,4 +1,7 @@ # Code Review Changes + +Original tables with verbatim feedback can be found in [this Google Doc](https://docs.google.com/document/d/19d5U-ieQyGVVNQjj0rUouzIqF53evEP6yss-wyqNXiQ/edit?usp=sharing). + |Comment|Adjustment| |-------|----------| |Some variables are unused.| Some unused variables needed for external library configuration; others have been removed in the process of refactoring.|