CS-46X
/
collar
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add code review remarks.

This commit is contained in:
Danila Fedorin 2020-05-15 21:50:52 -07:00
parent a33b6c39eb
commit b83cd25169
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
REVIEW.md Normal file
View File

@ -0,0 +1,7 @@
# Code Review Changes
|Comment|Adjustment|
|-------|----------|
|Some variables are unused.| Some unused variables needed for external library configuration; others have been removed in the process of refactoring.|
|Comments are lacking.| File has been thoroughly commented.|
|Replace `coord*x` and `coord*y` with arrays (undo unroll). | No action taken. The variables are this way due to the restrictions of the team's protobuf library, which is the only library capable of generating code small enough to fit on the hardware.|
|Few unit tests.|Some unit tests added to the code for encoding and decoding.|